Skip to content

[Custom scalars] Implement scalar option in field policies with cache reads - #13258

Closed
jerelmiller wants to merge 32 commits into
jerel/custom-scalar-configfrom
jerel/type-policy-config
Closed

[Custom scalars] Implement scalar option in field policies with cache reads#13258
jerelmiller wants to merge 32 commits into
jerel/custom-scalar-configfrom
jerel/type-policy-config

Conversation

@jerelmiller

@jerelmiller jerelmiller commented Jun 4, 2026

Copy link
Copy Markdown
Member

Part of the custom scalars work: #13227

Adds the scalar option for field policies so that fields can specify which scalar to use. This change also implements scalar parsing for cache reads so that cache.readQuery, cache.readFragment, and cache.watchFragment all return the parsed scalar values for fields that specify a scalar.

jerelmiller added 23 commits June 3, 2026 20:38
@jerelmiller
Add scalar option to FieldPolicy
4070d60
@jerelmiller
Use 2026 as year
a31d83b
@jerelmiller
Add scalar to internal type
3c1c848
@jerelmiller
Set scalar on field policy
daa6efe
@jerelmiller
Add failing tests for custom scalars
be56aff
@jerelmiller
Add scalar coercion to policies
a56e229
@jerelmiller
Better handle parsing scalars from nested arrays
44703bc
@jerelmiller
Don't try and coerce null
383f3d7
@jerelmiller
Handle object-based scalar values
08bb78b
@jerelmiller
Add test for primitive to primitive transform
e41cb41
@jerelmiller
Add test for scalar in object array
390d3a8
@jerelmiller
Add test to ensure multiple scalars work
33688db
@jerelmiller
Add test for named/inline fragment
9cce6f4
@jerelmiller
Add tests for union type
bbad0b6
@jerelmiller
Add test for interface type
48a4e1f
@jerelmiller
Add kitchen sink test
5b6c2f6
@jerelmiller
Add changeset
f8e62f1
@jerelmiller
Add dev-only warning for scalars configured on non-scalar fields
e052437
@jerelmiller
Remove outdated comment
be6aaca
@jerelmiller
Add test for cache.watchFragment
8c5053b
@jerelmiller
Move KnownScalars type to types file
1a7c14c
@jerelmiller
Provide better autocomplete for scalars that extends Record<string, ...>
1d70656
@jerelmiller
Update type tests with scalar config
d524093
@apollo-librarian

apollo-librarian Bot commented Jun 4, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

✅ Docs preview ready

The preview is ready to be viewed. View the preview

File Changes

0 new, 3 changed, 0 removed 
* (developer-tools)/react/(latest)/data/fragments.mdx
* (developer-tools)/react/(latest)/data/typescript.mdx
* (developer-tools)/react/(latest)/migrating/apollo-client-4-migration.mdx

Build ID: 43878d757ec32f261464ed6b
Build Logs: View logs

URL: https://www.apollographql.com/docs/deploy-preview/43878d757ec32f261464ed6b

✅ AI Style Review — No Changes Detected

No MDX files were changed in this pull request.

Review Log: View detailed log

This review is AI-generated. Please use common sense when accepting these suggestions, as they may not always be accurate or appropriate for your specific context.

@jerelmiller
jerelmiller requested a review from phryneas June 4, 2026 06:01
@coderabbitai

coderabbitai Bot commented Jun 4, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (1)
  • release-*

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 1eee4b2d-410f-489e-85ed-bd086510760b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@changeset-bot

changeset-bot Bot commented Jun 4, 2026 •
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 1ed51e1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@apollo/client Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new

pkg-pr-new Bot commented Jun 4, 2026 •
edited
Loading

Copy link
Copy Markdown 
npm i https://pkg.pr.new/apollographql/apollo-client/@apollo/client@13258

commit: 1ed51e1

@jerelmiller jerelmiller changed the title Implement scalar option in field policies with cache reads [Custom Scalars] Implement scalar option in field policies with cache reads Jun 5, 2026
@jerelmiller jerelmiller changed the title [Custom Scalars] Implement scalar option in field policies with cache reads [Custom scalars] Implement scalar option in field policies with cache reads Jun 5, 2026
@jerelmiller

jerelmiller commented Jun 8, 2026

Copy link
Copy Markdown
Member Author

Closing in favor of #13259 which incorporates these changes along with cache writes. We are going to change cache writes to store the parsed value rather than the serialized value which negates some of the changes in this PR, so it will be combined for better clarity.

@jerelmiller jerelmiller closed this Jun 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@phryneas phryneas Awaiting requested review from phryneas

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jerelmiller